feat: don't take control over DWO which is not managed by Che #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun,
nickboldt and
tolusha
as code owners
sleshchenko
force-pushed
the
managedDWO
branch
from
b5b6c3e
to
062e859
Compare
|
/test v7-devworkspace-happy-path |
|
v7-devworkspace-happy-path and the only failure I see, Che Operator reports:
|
tolusha
approved these changes
Sep 24, 2021
tolusha
reviewed
Sep 24, 2021
mmorhun
approved these changes
Sep 24, 2021
|
/test v7-devworkspace-happy-path |
sleshchenko
force-pushed
the
managedDWO
branch
from
062e859
to
dff323b
Compare
sleshchenko
force-pushed
the
managedDWO
branch
from
dff323b
to
eac4174
Compare
sleshchenko
changed the title
This comment has been minimized.
This comment has been minimized.
sleshchenko
force-pushed
the
managedDWO
branch
from
ccee98d
to
359ec07
Compare
This comment has been minimized.
This comment has been minimized.
tolusha
reviewed
Sep 27, 2021
sleshchenko
force-pushed
the
managedDWO
branch
4 times, most recently
from
282f7e8
to
1659d59
Compare
JPinkney
approved these changes
Sep 30, 2021
tolusha
reviewed
Oct 1, 2021
sleshchenko
force-pushed
the
managedDWO
branch
from
4cdd6ad
to
86a1b34
Compare
tolusha
reviewed
Oct 1, 2021
pkg/deploy/service_account.go
Outdated
Comment on lines
21
to
26
| isCreated, err := CreateIfNotExists(deployContext, saSpec) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| // we're done if SA already exist | ||
| return !isCreated, nil |
There was a problem hiding this comment.
Suggested change
| isCreated, err := CreateIfNotExists(deployContext, saSpec) | |
| if err != nil { | |
| return false, err | |
| } | |
| // we're done if SA already exist | |
| return !isCreated, nil | |
| _, err := CreateIfNotExists(deployContext, saSpec) | |
| return err == nil, err |
There was a problem hiding this comment.
well, it depends on policy whether we should do reconcile after object is created/modified or not.
tolusha
approved these changes
Oct 1, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, JPinkney, mmorhun, sleshchenko, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
sleshchenko
force-pushed
the
managedDWO
branch
from
04eeaea
to
54a66eb
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
This was referenced Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It's really annoying when you do
make installfrom DWO repo, and expect your custom DWO be installed, but then Che operator takes control over DWO.There is a weird way to workaround it - cluster DWO CSV, but I believe the proper solution is not to take control over DWO which is not managed by Che.
Initially, it was supposed to be simple PR, but then I noticed a few bugs and inaccuracies, so it also brings refactoring to the whole devworkspace package.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
N/A
How to test this PR?
unit tests pretty everything, but for manual test you may:
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.