Align JGroups labels property name with original one in KUBE_PING #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
|
Does this typo affect anything? Blocker for CRW 2.0 ? |
|
not really a blocker but better to have it to avoid possible confusions |
|
I just discussed with @mshaposhnik and there is a related Che server PR: eclipse-che/che#15282 which I assume will not be included in CRW 2.0 since it would require a respin of the Che server for something that is not critical. |
davidfestal
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
OK to merge it on master when eclipse-che/che#15282 is merged
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align JGroups labels property name with original one in
KUBE_PING(see https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/src/main/java/org/jgroups/protocols/kubernetes/KUBE_PING.java#L81)
So possible naming confusions may be avoided in future.
Issue to
KUBE_PINGupstream to align their documentation: jgroups-extras/jgroups-kubernetes#79