Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding 'spec.dashboard.warning' type to the CR #1330

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Mar 3, 2022

Signed-off-by: Ilya Buziuk ibuziuk@redhat.com

What does this PR do?

Adding 'spec.dashboard.warning' type to the CR
Related PR to the user dashboard - eclipse-che/che-dashboard#466

Screenshot/screencast of this PR

Verified against 4.8 cluster bot:

image

demo

What issues does this PR fix or reference?

eclipse-che/che#20724

How to test this PR?

cat EOF << > /tmp/patch.yaml
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 3, 2022

/test v8-operator-test

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, ibuziuk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 3, 2022

/test v8-operator-test

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 3, 2022

/test v9-upgrade-stable-to-next

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 3, 2022

/test v9-operator-test

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 3, 2022

/test v8-operator-test

@flacatus
Copy link
Contributor

flacatus commented Mar 3, 2022

/retest

1 similar comment
@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 4, 2022

/retest

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 4, 2022

/test v8-che-behind-proxy

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #1330 (b47f969) into main (104f679) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1330   +/-   ##
=======================================
  Coverage   60.52%   60.52%           
=======================================
  Files          77       77           
  Lines        6346     6346           
=======================================
  Hits         3841     3841           
  Misses       2119     2119           
  Partials      386      386           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104f679...b47f969. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants