Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 don't create che-workspace sa #139

Closed
wants to merge 2 commits into from

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Dec 16, 2019

Signed-off-by: Michal Vala mvala@redhat.com

che-server is responsible for che-workspace serviceaccount.

This PR

  • don't create che-workspace sa
  • pass CheWorkspaceClusterRole as CHE_INFRA_KUBERNETES_CLUSTER__ROLE__NAME to configmap for the server

TODO:

  • fix che_controller test
--- FAIL: TestCheController (31.04s)
    che_controller_test.go:173: Custom role binding  not found: rolebindings.rbac.authorization.k8s.io "che-workspace-custom" not found

Issue: eclipse-che/che#15300

…_INFRA_KUBERNETES_CLUSTER__ROLE__NAME in configmap

Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo sparkoo changed the title don't create che-workspace sa 🚧 don't create che-workspace sa Dec 16, 2019
Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo
Copy link
Member Author

sparkoo commented Dec 17, 2019

closing this as we need at least get roles permissions for che sa. Permissions should be solved in the scope of this issue eclipse-che/che#15493

@sparkoo sparkoo closed this Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant