Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Dev Workspace controller images accordingly to airgap se… #1391

Merged
merged 2 commits into from
May 23, 2022

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented May 23, 2022

…ttings

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented May 23, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tolusha tolusha marked this pull request as ready for review May 23, 2022 12:23
@openshift-ci
Copy link

openshift-ci bot commented May 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1391 (2edc175) into main (00d30e4) will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
+ Coverage   61.84%   61.88%   +0.03%     
==========================================
  Files          76       76              
  Lines        6275     6281       +6     
==========================================
+ Hits         3881     3887       +6     
  Misses       2007     2007              
  Partials      387      387              
Impacted Files Coverage Δ
pkg/deploy/defaults.go 44.89% <43.75%> (ø)
pkg/deploy/dev-workspace/dev_workspace_syncer.go 79.48% <100.00%> (+1.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d30e4...2edc175. Read the comment docs.

@tolusha tolusha merged commit 80609dd into main May 23, 2022
@tolusha tolusha deleted the 21268_2 branch May 23, 2022 14:08
@che-bot che-bot added this to the 7.48 milestone May 23, 2022
@tolusha tolusha mentioned this pull request Jul 4, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants