Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workspaces policies #1429

Merged
merged 3 commits into from
Jul 4, 2022
Merged

fix: workspaces policies #1429

merged 3 commits into from
Jul 4, 2022

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jul 1, 2022

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

This PR added the verb "get" to the "pods/exec" section

rules:
  - verbs:
      - create
      - get
    apiGroups:
      - ''
    resources:
      - pods/exec

since the client in the che-dashboard

...
        const url = `${k8sServer}/api/v1/namespaces/${namespace}/pods/${pod}/exec?${queryStr}`;

        const client = new WebSocket(url, PROTOCOLS, opts);
...

needs to send an HTTP GET to negotiate a WebSocket.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#21480

How to test this PR?

cat EOF << > /tmp/patch.yaml
<PATCH_CONTENT>
EOF

chectl server:deploy \
     --installer operator \
     --platform <PLATFORM_TO_DEPLOY> \
     --che-operator-image <CUSTOM_OPERATOR_IMAGE> \
     --che-operator-cr-patch-yaml /tmp/patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1429 (5489ace) into main (92b7a27) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5489ace differs from pull request most recent head e5565b0. Consider uploading reports for the commit e5565b0 to get more accurate results

@@           Coverage Diff           @@
##             main    #1429   +/-   ##
=======================================
  Coverage   60.35%   60.35%           
=======================================
  Files          74       74           
  Lines        6266     6266           
=======================================
  Hits         3782     3782           
  Misses       2113     2113           
  Partials      371      371           
Impacted Files Coverage Δ
pkg/deploy/rbac/workspace_permissions.go 66.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b7a27...e5565b0. Read the comment docs.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jul 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 2, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v9-devworkspace-happy-path 7b13034 link true /test v9-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Jul 2, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, olexii4, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 7e63fdb into main Jul 4, 2022
@olexii4 olexii4 deleted the che-21480 branch July 4, 2022 11:56
@che-bot che-bot added this to the 7.50 milestone Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http statusCode 500 - Could not add kubeconfig into containers in user namespace for dashboardApi
4 participants