Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ValidatingWebhookConfiguration to ensure only one CheCluste… #1518

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 16, 2022

…r is created

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Add ValidatingWebhookConfiguration to ensure only one CheCluster is created

Screenshot/screencast of this PR

screenshot-console-openshift-console apps ci-ln-isdrrfb-76ef8 origin-ci-int-aws dev rhcloud com-2022 09 16-13_22_25

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-3328

How to test this PR?

  1. Deloy Eclipse Che from CatalogSource docker.io/abazko/catalog:crw-3328.
  2. Try to create Eclipse Che CR

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…r is created

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2022

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v10-che-operator-update 9308411 link true /test v10-che-operator-update

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -0,0 +1,18 @@
#
# Copyright (c) 2019-2021 Red Hat, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new file created with historical copyright dates? :D

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, +1. Can't speak to the technical details however.

@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit e1a45d0 into 7.52.x Sep 19, 2022
@tolusha tolusha deleted the validatingwebhookconfiguration branch September 19, 2022 12:46
@che-bot che-bot added this to the 7.52 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants