Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly convert devfile version to a string #1863

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix: Properly convert devfile version to a string #1863

merged 1 commit into from
Jun 26, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jun 25, 2024

What does this PR do?

fix: Properly convert devfile version to a string

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-6612

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha
fix: Properly convert devfile version to a string
a3a2896 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 25, 2024 •
edited
Loading

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy a3a2896 link true /test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tolusha
Copy link
Contributor Author

tolusha commented Jun 25, 2024

/test v14-devworkspace-happy-path

@openshift-ci openshift-ci bot added the lgtm label Jun 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 6cfe452 into main Jun 26, 2024
20 of 21 checks passed
@tolusha tolusha deleted the CRW-6612 branch June 26, 2024 07:05
@devstudio-release
Copy link

Build 3.15 :: operator_3.x/375: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6953: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6900: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3114: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6959: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6907: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: push-latest-container-to-quay_3.x/4686: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: get-sources-rhpkg-container-build_3.x/6907: SUCCESS

devspaces-operator-bundle : 3.x :: Build 62228944 : quay.io/devspaces/devspaces-operator-bundle:3.15-7
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4686 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.15-2
- quay.io/devspaces/configbump-rhel8:3.15-1
- quay.io/devspaces/dashboard-rhel8:3.15-4
- quay.io/devspaces/devfileregistry-rhel8:3.15-13
- quay.io/devspaces/devspaces-rhel8-operator:3.15-7
- quay.io/devspaces/idea-rhel8:3.15-2
- quay.io/devspaces/pluginregistry-rhel8:3.15-1
- quay.io/devspaces/server-rhel8:3.15-2
- quay.io/devspaces/traefik-rhel8:3.15-1
- quay.io/devspaces/udi-rhel8:3.15-1
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202405222205.p0.gb17014f.assembly.stream.el8
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202405222205.p0.g03e5b13.assembly.stream.el8
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.x/6959: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/6907 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.x/3114: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6959 triggered

@devstudio-release
Copy link

Build 3.15 :: copyIIBsToQuay/2684: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: dsc_3.x/1932: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: dsc_3.x/1932: SUCCESS

3.15.0-CI

@devstudio-release
Copy link

Build 3.15 :: copyIIBsToQuay/2684: SUCCESS

3.15
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.15-7
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ x86_64-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.15-v4.16-750223- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.15-v4.16-750223- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.15-v4.16-x86_64
  + <a href=https://quay.io/devspaces/iib:3.15-v4.15-750213- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.15-v4.15-750213- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.15-v4.15-x86_64
  + <a href=https://quay.io/devspaces/iib:3.15-v4.14-750211- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.15-v4.14-750211- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.15-v4.14-x86_64
  + <a href=https://quay.io/devspaces/iib:3.15-v4.13-750206- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.15-v4.13-750206- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.15-v4.13-x86_64
  + <a href=https://quay.io/devspaces/iib:3.15-v4.12-750194- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.15-v4.12-750194- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.15-v4.12-x86_64
+ s390x-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.15-v4.16-750223- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.15-v4.16-750223- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.15-v4.16-s390x
  + <a href=https://quay.io/devspaces/iib:3.15-v4.15-750213- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.15-v4.15-750213- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.15-v4.15-s390x
  + <a href=https://quay.io/devspaces/iib:3.15-v4.14-750211- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.15-v4.14-750211- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.15-v4.14-s390x
  + <a href=https://quay.io/devspaces/iib:3.15-v4.13-750206- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.15-v4.13-750206- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.15-v4.13-s390x
  + <a href=https://quay.io/devspaces/iib:3.15-v4.12-750194- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.15-v4.12-750194- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.15-v4.12-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.15-v4.16-750223- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.15-v4.16-750223- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.15-v4.16-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.15-v4.15-750213- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.15-v4.15-750213- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.15-v4.15-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.15-v4.14-750211- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.15-v4.14-750211- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.15-v4.14-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.15-v4.13-750206- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.15-v4.13-750206- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.15-v4.13-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.15-v4.12-750194- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.15-v4.12-750194- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.15-v4.12-ppc64le

@devstudio-release
Copy link

Build 3.16 :: operator-bundle_3.x/3115: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: operator-bundle_3.x/3116: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: sync-to-downstream_3.x/6965: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6912: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6912: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 62229733 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.16 :: operator-bundle_3.x/3118: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: sync-to-downstream_3.x/6967: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6914: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6914: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 62229800 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.16 :: operator-bundle_3.x/3119: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: sync-to-downstream_3.x/6969: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6916: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6916: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 62229905 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.15/1: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.15/2: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: operator-bundle_3.x/3120: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: sync-to-downstream_3.x/6970: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6917: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6917: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 62231029 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.15/2: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.15/3: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: operator-bundle_3.x/3121: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: sync-to-downstream_3.x/6971: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6918: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6918: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 62232810 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.15 :: operator-bundle_3.15/3: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.15 :: sync-to-downstream_3.15/5: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: operator-bundle_3.x/3123: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: sync-to-downstream_3.x/6974: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6924: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6924: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 62234861 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@SDawley SDawley Awaiting requested review from SDawley SDawley is a code owner

Assignees

@ibuziuk ibuziuk

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tolusha @devstudio-release @ibuziuk