Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some defaults to env #247

Merged
merged 1 commit into from
May 13, 2020
Merged

Move some defaults to env #247

merged 1 commit into from
May 13, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented May 8, 2020

Signed-off-by: Anatoliy Bazko abazko@redhat.com

Reference issue

eclipse-che/che#16868

What does this PR do

Move some defaults to env var

This was referenced May 8, 2020
Closed
Closed
@nickboldt
Copy link
Contributor

What about these three vars?

	DefaultConsoleLinkImage               = "/dashboard/assets/branding/loader.svg"
...
	defaultConsoleLinkUpstreamDisplayName = "Eclipse Che"
	defaultConsoleLinkDisplayName         = "CodeReady Workspaces"

-- https://github.com/eclipse/che-operator/blob/master/pkg/deploy/defaults.go#L95-L99

@tolusha
Copy link
Contributor Author

tolusha commented May 12, 2020

@nickboldt
done

nickboldt
nickboldt approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ latest commit (more fields!)

davidfestal
davidfestal approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@davidfestal davidfestal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@tolusha
Move defaults to env var
b9942aa 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha merged commit c50bfa5 into master May 13, 2020
@tolusha tolusha deleted the movedefaultstoenv branch May 13, 2020 05:37
@tolusha tolusha mentioned this pull request May 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt approved these changes

@davidfestal davidfestal davidfestal approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@rhopp rhopp Awaiting requested review from rhopp

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tolusha @nickboldt @davidfestal @AndrienkoAleksandr