Added support for ppc64le #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junawaneshivani
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp,
tolusha and
vparfonov
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
nickboldt
reviewed
May 14, 2020
56 tasks
Signed-off-by: Shivani Junawane <shivanij@us.ibm.com>
|
@nickboldt PR now supports all architectures as suggested... |
nickboldt
reviewed
May 15, 2020
| @@ -23,6 +23,7 @@ ADD . /go/src/github.com/eclipse/che-operator | |||
| RUN case $(uname -m) in \ | |||
| x86_64) ARCH="amd64" ;; \ | |||
| s390x) ARCH="s390x";; \ | |||
| ppc64le) ARCH="ppc64le";; \ | |||
There was a problem hiding this comment.
I might suggest making this less hard-coded and more generic... for s390x, ppc64le, and even future arches...
x86_64) ARCH="amd64" ;; \
*) ARCH="$1" ;; \
There was a problem hiding this comment.
why merging instead of having the suggested proper fix for other arches ?
nickboldt
reviewed
May 15, 2020
| @@ -23,6 +23,7 @@ ADD . /go/src/github.com/eclipse/che-operator | |||
| RUN case $(uname -m) in \ | |||
| x86_64) ARCH="amd64" ;; \ | |||
| s390x) ARCH="s390x";; \ | |||
| ppc64le) ARCH="ppc64le";; \ | |||
| esac | |||
|
|
|||
| # do no break RUN lines when building with UBI base images. https://projects.engineering.redhat.com/browse/OSBS-7398 & OSBS-7399 | |||
There was a problem hiding this comment.
FYI this comment is no longer correct. Broken lines are allowed in Brew.
nickboldt
approved these changes
May 15, 2020
|
Followup #266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I have added support for ppc64le architecture with reference to the PR merged for s390x architecture.