crw-927 Adding 'operatorframework.io/cluster-monitoring: true' label to the OpenShift nightly csv files #339
Conversation
ibuziuk
requested review from
davidfestal,
l0rd,
nickboldt,
tolusha and
vparfonov
as code owners
|
@tolusha could you please review - would be great to merge it for 7.16.0 ;) |
|
Latest version of Eclipse Che failed installation in minishift. |
| description: A Kube-native development solution that delivers portable and collaborative | ||
| developer workspaces. | ||
| operatorframework.io/suggested-namespace: eclipse-che | ||
| + operatorframework.io/cluster-monitoring: "true" |
There was a problem hiding this comment.
Does it make sense for raw, non-OpenShift Kubernetes installations ?
There was a problem hiding this comment.
@davidfestal technically, it should be possible to install on OpenShift via the kubernetes csv, right?
In general, this property would make sense only for CRW, but I thought that CRW csv will fall back on upsteam, no?
There was a problem hiding this comment.
it should be possible to install on OpenShift via the kubernetes csv, right?
well, that's not recommended at all. Not even sure it works.
CRW csv will fall back on upsteam
Not sure what you mean here ? CRW CSV is based on the upstream OpenShift CSV
Are we mixing upstream Che and upstream Kubernetes here ?
|
Latest version of Eclipse Che installed and tested successfully in minikube. |
…to the openshift csv files Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
ibuziuk
changed the title
|
@davidfestal PR has been updated adding 'operatorframework.io/cluster-monitoring: true' label only to OpenShift csv |
|
Latest version of Eclipse Che failed installation in minishift. |
|
Latest version of Eclipse Che installed and tested successfully in minikube. |
|
[test] |
|
Latest version of Eclipse Che failed installation in minishift. |
|
Latest version of Eclipse Che installed and tested successfully in minikube. |
|
@ibuziuk please ignore minishift tests. I will create a separate Pr to fix them |
operatorframework.io/cluster-monitoring: "true" is a pre-requirement for openshift cluster monitoring - https://github.com/openshift/enhancements/blob/master/enhancements/olm/olm-managed-operator-metrics.md#namespace-requirements
Once the label is applied it will be possible to opt in for the cluster monitoring: