Include registries in Che deployment #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
... as in PR https://github.com/eclipse/che/pull/13890/files#diff-a488b4bdede7547798a17f6830874b05R59 Signed-off-by: David Festal <dfestal@redhat.com>
since, in the Che case, `cheFlavor` is always passed as the `name` parameter. Signed-off-by: David Festal <dfestal@redhat.com>
based on additional status fields Signed-off-by: David Festal <dfestal@redhat.com>
to also change default image tag of registry containers Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
requested review from
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
nickboldt
reviewed
Jul 18, 2019
nickboldt
reviewed
Jul 18, 2019
nickboldt
reviewed
Jul 18, 2019
nickboldt
reviewed
Jul 18, 2019
nickboldt
reviewed
Jul 18, 2019
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
changed the title
|
@nickboldt @l0rd is it OK for you now ? |
l0rd
approved these changes
Jul 19, 2019
Signed-off-by: David Festal <dfestal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the implementation, on the Che operator side, of issues eclipse-che/che#13557 and redhat-developer/rh-che#1476