Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Add ability to configure several extensions in a single VS Code plugin #36

Merged
merged 4 commits into from
Mar 15, 2019
Merged

Add ability to configure several extensions in a single VS Code plugin #36

merged 4 commits into from
Mar 15, 2019

Conversation

garagatyi
Copy link

@garagatyi garagatyi commented Mar 13, 2019 •
edited
Loading

What does this PR do?

This PR is designed to be reviewed in a commit-by-commit manner. This simplifies diffs of commits significantly and doesn't shuffle them.
Add ability to configure several extensions in a single VS Code plugin.
Both URLs and extension IDs are supported.
Format:

id: blah
version: blah
attributes:
  blah
extensions:  
 - vscode:extension/SonarSource.sonarlint-vscode
 - https://marketplace.visualstudio.com/_apis/public/gallery/publishers/redhat/vsextensions/java/0.38.0/vspackage
 - https://marketplace.visualstudio.com/_apis/public/gallery/publishers/redhat/vsextensions/vscode-xml/0.3.0/vspackage

What issues does this PR fix or reference?

eclipse-che/che#12395

@garagatyi garagatyi force-pushed the shareSidecar branch 2 times, most recently from 3ea3b9b to 359d6ca Compare March 13, 2019 17:36
@garagatyi garagatyi marked this pull request as ready for review March 15, 2019 07:55
@garagatyi garagatyi force-pushed the shareSidecar branch 2 times, most recently from f84af19 to 74a05d0 Compare March 15, 2019 10:31
Oleksandr Garagatyi added 3 commits March 15, 2019 12:33
Add extensions list to meta model
27cff59 
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Allow adding plugins to sidecar tooling separately
6964e04 
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Add config for manual testing of several VS Code extensions in one pl…
18e069e 
…ugin

Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@garagatyi
Copy link
Author

I had messed up with the commits splitting, so, I pushed with force after fixing that

sleshchenko
sleshchenko approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brokers/vscode/broker.go Outdated Show resolved Hide resolved
Make VS Code broker support several extensions in one Che plugin
cdd0b77 
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@garagatyi garagatyi merged commit 558a27f into master Mar 15, 2019
@garagatyi garagatyi deleted the shareSidecar branch March 15, 2019 14:25
@tsmaeder tsmaeder mentioned this pull request Mar 19, 2019
Closed
22 tasks
@tsmaeder tsmaeder mentioned this pull request Apr 5, 2019
Closed
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfestal davidfestal davidfestal approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@amisevsk amisevsk Awaiting requested review from amisevsk amisevsk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garagatyi @davidfestal @sleshchenko