This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
[WIP] Use localhost
in plugin endpoints by default
#56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since, in the current Che implementation, all plugin containers are run on the same POD as the Theia IDE container, let's change the default behavior of the plugin brokers to use
localhost
as the IP of side-car plugin endpoints, instead of using the short service name, which, in some cases, cannot be reached.What issues does this PR fix or reference?
eclipse-che/che#11018
Has this PR been tested ?
Yes, on Minishift Che Addon with the v2 prod-preview plugin registry, the nightly che-server docker image, and the modified unified plugin broker.