This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Make broker preserve extensions for downloaded plugins #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add function DownloadPreserveFilename to ioutil
- Attempts to use Content-Disposition header to determine filename
- If unable, behaves as previous Download() function
- Necessary for keeping file extensions (e.g. .theia for theia
plugins)
- Make broker add file extension, if available, to copied local plugins
- This is necessary as files without .theia extension are not picked
up as plugins at workspace runtime
- Remove mentions of VS Code in logging when step can apply to Theia
plugins as well
- gofmt ran automatically on edited files so there are some formatting
changes.
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 62.52% 60.17% -2.36%
==========================================
Files 6 6
Lines 555 580 +25
==========================================
+ Hits 347 349 +2
- Misses 182 204 +22
- Partials 26 27 +1
Continue to review full report at Codecov.
|
|
cc: @vitaliy-guliy Built PR is available on dockerhub at |
|
Closing as it will be implemented as part of #60 (which makes other changes to VS Code/Theia plugin processing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DownloadPreserveFilenametoioutilDownload()function.theiafor theiaplugins)
.theiaextension are not pickedup as plugins at workspace runtime
plugins as well
gofmtran automatically on edited files so there are some formattingchanges.
What issues does this PR fix or reference?
eclipse-che/che#13349