Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete deprecated Theia editor plugin version #127

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Delete deprecated Theia editor plugin version #127

merged 1 commit into from
Apr 25, 2019

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Apr 24, 2019

What does this PR do?

This PR deletes deprecated Theia editor of master version.
This will help to avoid confusion between Theia editor versions.
Instead of deleted master version, Theia with version next should be used.

@mmorhun mmorhun self-assigned this Apr 24, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Apr 24, 2019

Please be careful and do not update prod due to redhat-developer/rh-che#1379

@benoitf
Copy link
Contributor

benoitf commented Apr 24, 2019

@ibuziuk it should be good to remove master

it will let : latest and next

@garagatyi
Copy link

@ibuziuk won't it break Che 7 workspaces on prod-preview, will it? I assume prod-preview is updated on each commit

@ibuziuk
Copy link
Member

ibuziuk commented Apr 24, 2019

@garagatyi sure what I mean is that this PR should not be merged until relevant changes are done in the rh-che

@garagatyi
Copy link

Please note that I added CircleCI and Eclipse sign off check to required checks for PRs.
Since this PR was created before CircleCI was configured in the repository you have to commit something to this PR to initiate CircleCI build that is required to proceed with merging the PR.
Sorry for the inconvenience.

@ibuziuk ibuziuk self-requested a review April 25, 2019 05:33
ibuziuk
ibuziuk approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I checked che.openshift.io stacks and we use the master version of theia in none. @mmorhun +1 to merge and rollout to prod

@ibuziuk
Copy link
Member

ibuziuk commented Apr 25, 2019

@mmorhun I believe https://github.com/eclipse/che-plugin-registry/blob/master/v2/plugins/eclipse/che-theia/master/meta.yaml should be also removed now

@mmorhun
Delete deprecated Theia editor plugin version
2258ddf 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun force-pushed the delete-deprecated-theia-editor branch from 9140370 to 2258ddf Compare April 25, 2019 06:26
@mmorhun
Copy link
Contributor Author

mmorhun commented Apr 25, 2019

@ibuziuk thanks, I've updated PR. But that's kinda surprise, because when I created it, v2 directory didn't exist.

@ashumilova ashumilova mentioned this pull request Apr 25, 2019
Closed
25 tasks
@mmorhun mmorhun merged commit a3ed48b into master Apr 25, 2019
@mmorhun mmorhun deleted the delete-deprecated-theia-editor branch April 25, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@ibuziuk ibuziuk ibuziuk approved these changes

@olexii4 olexii4 olexii4 approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@evidolob evidolob Awaiting requested review from evidolob

@ashumilova ashumilova Awaiting requested review from ashumilova

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy

Assignees

@mmorhun mmorhun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmorhun @ibuziuk @benoitf @garagatyi @olexii4 @AndrienkoAleksandr