-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Do not ignore events and commands for an editor #1613
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## main #1613 +/- ##
==========================================
+ Coverage 93.63% 93.68% +0.05%
==========================================
Files 47 47
Lines 1445 1457 +12
Branches 247 253 +6
==========================================
+ Hits 1353 1365 +12
Misses 92 92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with local build and got a devfile.yaml for che-code with commads and events:
schemaVersion: 2.1.0
metadata:
name: che-code
commands:
- id: init-container-command
apply:
component: che-code-injector
- id: init-che-code-command
exec:
component: che-code-runtime-description
commandLine: nohup /checode/entrypoint-volume.sh > /checode/entrypoint-logs.txt 2>&1 &
events:
preStart:
- init-container-command
postStart:
- init-che-code-command
components:
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RomanNikitenko, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/retest-required |
What does this PR do?
At the moment there is a bug: events and commands defined for an editor in the che-editors.yaml file are ignored. See #1566 (review)
The PR fixes that problem.
What issues does this PR fix or reference?
eclipse-che/che#22071
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.