Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Che 7.1.0 version of the plugin-registry #216

Merged
merged 4 commits into from
Sep 4, 2019

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Sep 4, 2019

What does this PR do?

Release Che 7.1.0 version of the plugin-registry eclipse-che/che#14352:

  • Bumping VERSION file
  • Adding '7.1.0' versions for che-theia & machine-exec
  • Setting 'latest' version for che-theia and machine-exec plugins to '7.1.0' (latest = latest release version)
  • Setting '7.1.0' version for container runtime images of the che remote plugins - find . -name '*.yaml' -exec sed -i -e 's/:next/:7.1.0/g' {} \;

Please review in commit-by-commit manner

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
…plugins

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
…ugins to '7.1.0'

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk ibuziuk changed the title Release Che 7.1.0 version of the plugin-registry [WIP]Release Che 7.1.0 version of the plugin-registry Sep 4, 2019
…m 'next' to '7.1.0'

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
@ibuziuk ibuziuk changed the title [WIP]Release Che 7.1.0 version of the plugin-registry Release Che 7.1.0 version of the plugin-registry Sep 4, 2019
@ibuziuk ibuziuk mentioned this pull request Sep 4, 2019
21 tasks
@benoitf
Copy link
Contributor

benoitf commented Sep 4, 2019

hello, AFAIK branch had by conventions 7.1.x and tags were 7.1.0
here it seems that branch and tags will be the same ?

@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 4, 2019

@benoitf hi, we did the same for 7.0.0 release so I also created 7.1.0 the very same way. Currently, there are no tags for plugin / devfile registry at all. But I agree we do need to standardize the release process since currently it is pretty messy

@benoitf
Copy link
Contributor

benoitf commented Sep 4, 2019

icon: https://raw.githubusercontent.com/theia-ide/theia/master/logo/theia-logo-no-text-black.svg?sanitize=true
category: Editor
repository: https://github.com/eclipse/che-theia
firstPublicationDate: "2019-03-07"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that it's today the first publication date for che-theia 7.1.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, but I believe we have not updated the firstPublicationDate before and it might be assumed that firstPublicationDate = firstPublicationDate of plugin in general, but I'm not sure

@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 4, 2019

ok, I can rename the branch but it will not be consistent with https://github.com/eclipse/che-devfile-registry

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine for me

@ibuziuk ibuziuk changed the base branch from 7.1.0 to 7.1.x September 4, 2019 10:05
@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 4, 2019

@benoitf changed the branch to 7.1.x also done the same for devfile-registry:

@ibuziuk ibuziuk merged commit b3cf8c6 into eclipse-che:7.1.x Sep 4, 2019
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants