Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AsciiDoc plugin #218

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Add AsciiDoc plugin #218

merged 1 commit into from
Sep 9, 2019

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Sep 5, 2019 •
edited
Loading

What does this PR do?

Add AsciiDoc plugin to this registry

eclipse-che/che#14196

@olexii4 olexii4 force-pushed the CHE-14196 branch 2 times, most recently from 18b2469 to ed39a95 Compare September 5, 2019 09:51
amisevsk
amisevsk reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some inconsistency with versions used; why don't we just use 2.7.6?

v3/plugins/joaompinto/asciidoctor-vscode/latest/meta.yaml Outdated Show resolved Hide resolved
@amisevsk
Copy link
Contributor

amisevsk commented Sep 5, 2019

There's also an issue with there the metas are located; we still require meta.yaml to be in the v3/plugins/publisher/name/version/ folder, so they should be in v3/plugins/joaompinto/AsciiDoctor/latest

@olexii4
Copy link
Contributor Author

olexii4 commented Sep 5, 2019

@amisevsk I have fixed

@olexii4 olexii4 mentioned this pull request Sep 5, 2019
Merged
@olexii4
Copy link
Contributor Author

olexii4 commented Sep 6, 2019

@amisevsk I have fixed

amisevsk
amisevsk approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the plugin:

Screenshot from 2019-09-06 09-11-26

Only issue is that it requires the light theme -- the font colors do no change on the dark theia theme so it's black text on dark-grey background.

@olexii4
Copy link
Contributor Author

olexii4 commented Sep 6, 2019

@vitaliy-guliy '*.png' is wrong icon type
Screenshot from 2019-09-06 18-02-42

@olexii4
Copy link
Contributor Author

olexii4 commented Sep 6, 2019

Sorry. This PR was rebased and need rereview.

@olexii4 olexii4 merged commit d41870b into master Sep 9, 2019
@olexii4 olexii4 deleted the CHE-14196 branch September 9, 2019 08:52
@apupier apupier restored the CHE-14196 branch September 9, 2019 11:50
@olexii4 olexii4 deleted the CHE-14196 branch December 5, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@rhopp rhopp Awaiting requested review from rhopp

@vparfonov vparfonov Awaiting requested review from vparfonov

@mmorhun mmorhun Awaiting requested review from mmorhun

@sunix sunix Awaiting requested review from sunix

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy

@amisevsk amisevsk Awaiting requested review from amisevsk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olexii4 @amisevsk @skabashnyuk @vitaliy-guliy @AndrienkoAleksandr