Add list of external images to server when offline registry is built #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
requested review from
l0rd,
rhopp,
skabashnyuk and
vparfonov
as code owners
To aid in deploying Che in an offline scenario, it's necessary to have a list of images used in plugins. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
list-referenced-images
branch
from
9954a69 to
ae6326f
Compare
nickboldt
approved these changes
Oct 23, 2019
|
Looks good, worked well on the crw plugin reg. Merged. |
ibuziuk
pushed a commit
to ibuziuk/che-plugin-registry
that referenced
this pull request
Oct 28, 2019
…clipse-che#265) To aid in deploying Che in an offline scenario, it's necessary to have a list of images used in plugins. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
ibuziuk
pushed a commit
that referenced
this pull request
Oct 28, 2019
…265) To aid in deploying Che in an offline scenario, it's necessary to have a list of images used in plugins. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds building a list of externally-referenced images to the offline build to make it easier for users to know which images need to be pulled into a private registry.
Required for eclipse-che/che#14866