Make sure theia-remote-runtime-binary image is included in airgap #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
requested review from
l0rd,
rhopp,
skabashnyuk and
vparfonov
as code owners
- Update list_referenced_images.sh to include images in initcontainers (e.g. for theia) - Update entrypoint to do replacement for all images instead of just first - Update existing metas to include registry Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
airgap-fixup
branch
from
85e18d9 to
e61f795
Compare
nickboldt
approved these changes
Oct 31, 2019
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make sure that init container added for remote runtime injection is included in existing airgap functionality.