-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPU limitation #471
Add CPU limitation #471
Conversation
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Happy path tests passed. |
1 similar comment
Happy path tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM but should be tested. In many cases we're providing a lower cpuLimit
than plugins had to begin with -- e.g. on che.openshift.io, cpuLimit was/is set to 2x the memoryLimit. E.g. for the java plugin, this means going from 3 CPUs allocated to 0.5.
A few comments:
|
@@ -78,10 +78,11 @@ spec: | |||
- exposedPort: 13131 | |||
- exposedPort: 13132 | |||
- exposedPort: 13133 | |||
memoryLimit: "512M" | |||
memoryLimit: 512M | |||
cpuLimit: 500m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it really work well?
The benchmarks @vzhukovs did in eclipse-che/che#18565 (comment) say the opposite - with 500m Che-Theia slows down significantly. See the Measurement 3
.
Obsoleted by #774 |
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
What does this PR do?
Adds necessary CPU limitation for the plugin container configuration
Solves eclipse-che/che#16685
A sheet with a list of images used in plugins
https://docs.google.com/spreadsheets/d/1twoMLRC2A6YjTGiqXGvGvZP_M8GuKGydK75vhXQor2A/edit?usp=sharing