add vuejs extension to plugin registry #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
gattytto
requested review from
benoitf,
ericwill,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
svor
reviewed
Aug 26, 2020
Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
ericwill
reviewed
Aug 27, 2020
Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com>
ericwill
approved these changes
Aug 27, 2020
| displayName: Vetur | ||
| title: Rich Vue.js support | ||
| description: Vue tooling for VS Code | ||
| icon: https://upload.wikimedia.org/wikipedia/commons/9/95/Vue.js_Logo_2.svg |
There was a problem hiding this comment.
I think it's better to change the icon on
https://raw.githubusercontent.com/vuejs/vetur/v0.26.1/asset/vue.png
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Esteban Mañaricua emanaricua@gmail.com
Closes eclipse-che/che#13672
@ericwill it seems like the vetur sidecar is not needed for now but "peek definition" is not implemented in the extension so there might be a need to talk with vuejs devs (they use discord) and ask them if we'll have to add extra bins to the sidecar for a more complete language server that includes peek definition (of own projects parts and also for external included parts in the project).