fix: Improve GitHub token validation check #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
tolusha
approved these changes
Jul 13, 2022
|
@vinokurig thank you! could you please backport to 7.50.x ? |
vinokurig
added a commit
that referenced
this pull request
Jul 14, 2022
Do not throw an exception when validating an expired oauth token, return false instead. When a factory starts and oauth token is found, che-server checks the token: current behaiviour: if the oauth token is not valid, the validation check throws an exception and the factory creation is interrupted. PR behaviour: if the oauth token is not valid, the validation check returns false instead of an error, so token regeneration mechanism starts and the factory is created successfully.
9 tasks
vinokurig
added a commit
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What does this PR do?
Do not throw an exception when validating an expired oauth token, return
falseinstead.When a factory starts and oauth token is found, che-server checks the token:
falseinstead of an error, so token regeneration mechanism starts and the factory is created successfully.Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#21421
How to test this PR?
quay.io/ivinokur/che-server:nextimage e.g.chectl server:deploy -p=minikube -i=quay.io/ivinokur/che-server:nextSee: Che will regenerate the token and start the facory.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.