chore: Fix Gitlab raw file location url #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
tolusha
approved these changes
Oct 2, 2022
vinokurig
added a commit
that referenced
this pull request
Oct 4, 2022
Rework the Gitlab raw file url function to return a public raw file url instead of an API request. Trim the gitlabEndpoint if it ends with /
vinokurig
added a commit
that referenced
this pull request
Oct 4, 2022
Rework the Gitlab raw file url function to return a public raw file url instead of an API request. Trim the gitlabEndpoint if it ends with /
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What does this PR do?
gitlabEndpointif it ends with/Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#21696
How to test this PR?
Try to create a factory from a public Gitlab repo without the Gitlab OAuth being configured.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.