Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CRW-3802 CRW-3803 update to com.fasterxml.jackson 2.14.1 to fix CVEs #415

Merged
merged 6 commits into from
Jan 11, 2023

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Jan 10, 2023

What does this PR do?

chore: CRW-3802 CRW-3803 update to com.fasterxml.jackson 2.14.1 to fix CVEs

Change-Id: I4b146c16536741751146a9700eea1027064015f0
Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-3803
https://issues.redhat.com/browse/CRW-3802

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…x CVEs

Change-Id: I4b146c16536741751146a9700eea1027064015f0
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt changed the title chore: CRW-3802 CRW-3803 udpate to... chore: CRW-3802 CRW-3803 update to... Jan 10, 2023
@nickboldt nickboldt changed the title chore: CRW-3802 CRW-3803 update to... chore: CRW-3802 CRW-3803 update to com.fasterxml.jackson 2.14.1 to fix CVEs Jan 10, 2023
Change-Id: I21c6b53f6df37e684659e9d9604bc15271bc7e3a
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt
Copy link
Contributor Author

nickboldt commented Jan 10, 2023

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project che-core-api-workspace: Compilation failure
[ERROR] /home/nboldt/5-Che/0.github_upstream/che-server/wsmaster/che-core-api-workspace/src/test/java/org/eclipse/che/api/workspace/server/devfile/DevfileParserTest.java:[197,44] reference to treeToValue is ambiguous
[ERROR]   both method <T>treeToValue(com.fasterxml.jackson.core.TreeNode,java.lang.Class<T>) in com.fasterxml.jackson.databind.ObjectMapper and method <T>treeToValue(com.fasterxml.jackson.core.TreeNode,com.fasterxml.jackson.databind.JavaType) in com.fasterxml.jackson.databind.ObjectMapper match

Not sure how to fix this in https://github.com/eclipse-che/che-server/blob/CRW-3802/wsmaster/che-core-api-workspace/src/test/java/org/eclipse/che/api/workspace/server/devfile/DevfileParserTest.java#L197

Any advice from Java experts / former code owners like @vinokurig @skabashnyuk @sparkoo @mshaposhnik @amisevsk ?

@vinokurig
Copy link
Contributor


Change to:
doThrow(jsonException).when(jsonMapper).treeToValue(any(), eq(DevfileImpl.class));
to fix the error.

…for the fix!

Change-Id: I436df0c7f9e9557d348fc7faab44379fe510d643
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt
Copy link
Contributor Author

Now failing with this cryptic whatsit:

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireDepMgt failed with message:
junit:junit:jar is not managed by dependency management
You are trying to use artifacts that are not in the list of allowed artifacts included in
                                        dependencyManagement in root pom or have different version.

But if I revert the change to put in a version, I get:

[ERROR]   The project org.eclipse.che.multiuser:che-multiuser-keycloak-token-provider:7.60.0-SNAPSHOT (/home/nboldt/5-Che/0.github_upstream/che-server/multiuser/keycloak/che-multiuser-keycloak-token-provider/pom.xml) has 1 error
[ERROR]     'dependencies.dependency.version' for junit:junit:jar is missing. @ line 81, column 21

Change-Id: Iec554595866649c7480209463eaa64c12a2f6e96
Signed-off-by: Nick Boldt <nboldt@redhat.com>
Change-Id: I6d72fc133bbedb99875051041e221af5892f3323
Signed-off-by: Nick Boldt <nboldt@redhat.com>
Change-Id: I9bfa72bec71c5b8a009f4a4ac22012aa4b47038d
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt merged commit 0337316 into main Jan 11, 2023
@nickboldt nickboldt deleted the CRW-3802 branch January 11, 2023 19:04
@devstudio-release
Copy link

Build 3.5 :: server_3.x/104: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@che-bot che-bot added this to the 7.60 milestone Jan 11, 2023
@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.5 :: update-digests_3.x/1843: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: push-latest-container-to-quay_3.x/1515: SUCCESS

Copied: server-rhel8; /job/DS_CI/job/update-digests_3.x triggered;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.5 :: copyIIBsToQuay/658: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: sync-to-downstream_3.x/1968: SUCCESS

Build container: devspaces-server synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1897 triggered;

@devstudio-release
Copy link

Build 3.5 :: server_3.x/104: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1968 triggered

@devstudio-release
Copy link

Build 3.5 :: operator-bundle_3.x/765: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.5 :: copyIIBsToQuay/659: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: push-latest-container-to-quay_3.x/1516: UNSTABLE

Copied: devspaces-operator-bundle; Quay/Brew version mismatch; all Quay images updated; bundle-generated updated;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.12 v4.11 v4.10

@devstudio-release
Copy link

Build 3.5 :: sync-to-downstream_3.x/1969: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/1898 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.5 :: operator-bundle_3.x/765: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/1969 triggered

@devstudio-release
Copy link

Build 3.5 :: dsc_3.x/560: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.5 :: update-digests_3.x/1843: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.x/765 triggered

@devstudio-release
Copy link

Build 3.5 :: dsc_3.x/560: SUCCESS

3.5.0 CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants