fix: Simplification of the 'canCreateNamespace' logic

[ibuziuk]

What does this PR do?

Simplification of the 'canCreateNamespace' logic, checking only single property namespaceCreationAllowed as part of the method.

Screenshot/screencast of this PR

canCreateNamespace has a pretty sophisticated logic. Since we do not store any relevant data in the db anymore (see #398 for additional details) this resulted in the bug when the username contains special characters and can not be used as-is as a placeholder for k8s namespace / OpenShift project.

However, at this point, we probably do not need at all such checks since those were relevant only when workspaces were created and managed by che-server

What issues does this PR fix or reference?

eclipse-che/che#21958

NOTE: should be also backported to 7.60.x for Eclipse Che 7.60.1 and Dev Spaces 3.5

How to test this PR?

image quay.io/ibuziuk/che-server:che-21958

spec:
  components:
    cheServer:
      debug: true
      logLevel: INFO
      deployment:
        containers:
          - image: 'quay.io/ibuziuk/che-server:che-21958'
            name: che

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[tolusha]

Neat solution!

[karatkep]

Very nice and straightforward solution! Great job @ibuziuk !

[devstudio-release]

Build 3.6 :: server_3.x/111: Console, Changes, Git Data

[devstudio-release]

Build 3.6 :: sync-to-downstream_3.x/2178: Console, Changes, Git Data

[devstudio-release]

Build 3.6 :: get-sources-rhpkg-container-build_3.x/2070: Console, Changes, Git Data

[devstudio-release]

Build 3.6 :: push-latest-container-to-quay_3.x/1636: Console, Changes, Git Data

[devstudio-release]

Build 3.6 :: push-latest-container-to-quay_3.x/1636:

Copied: server-rhel8; Quay/Brew version mismatch; all Quay images updated; /job/DS_CI/job/update-digests_3.x triggered;
/job/DS_CI/job/Releng/job/copyIIBsToQuay triggered for OCP v4.13 v4.12 v4.11 v4.10

[devstudio-release]

Build 3.6 :: update-digests_3.x/2051: Console, Changes, Git Data

[devstudio-release]

Build 3.6 :: get-sources-rhpkg-container-build_3.x/2070:

server : 3.x :: Build 50455166 : quay.io/devspaces/server-rhel8:3.6-1
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/1636 triggered

[devstudio-release]

Build 3.6 :: copyIIBsToQuay/787: Console, Changes, Git Data

[devstudio-release]

Build 3.6 :: sync-to-downstream_3.x/2178:

Build container: devspaces-server synced; /DS_CI/get-sources-rhpkg-container-build_3.x/2070 triggered;

[devstudio-release]

Build 3.6 :: server_3.x/111:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/2178 triggered

[devstudio-release]

Build 3.6 :: operator-bundle_3.x/822: Console, Changes, Git Data

[devstudio-release]

Build 3.6 :: sync-to-downstream_3.x/2181: Console, Changes, Git Data

[devstudio-release]

Build 3.6 :: get-sources-rhpkg-container-build_3.x/2072: Console, Changes, Git Data

[devstudio-release]

Build 3.6 :: get-sources-rhpkg-container-build_3.x/2072:

devspaces-operator-bundle : 3.x :: Failed in 50455692 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay