Pass string to ObjectMapper instead of InputStream #531

vinokurig · 2023-07-11T11:22:31Z

What does this PR do?

Pass string to ObjectMapper instead of InputStream in order to avoid No content to map due to end-of-input error caused by jdk.internal.net.http.ResponseSubscribers$HttpResponseInputStream.
An error was discovered in our customers environment:

2023-07-07 11:31:31,713[nio-8080-exec-2]  [ERROR] [o.e.c.a.f.s.g.GithubApiClient 117]   - Error while parsing response body
com.fasterxml.jackson.databind.exc.MismatchedInputException: No content to map due to end-of-input
 at [Source: (jdk.internal.net.http.ResponseSubscribers$HttpResponseInputStream); line: 1, column: 0]
	at com.fasterxml.jackson.databind.exc.MismatchedInputException.from(MismatchedInputException.java:59)
	at com.fasterxml.jackson.databind.ObjectMapper._initForReading(ObjectMapper.java:4821)
	at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4723)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3714)
	at org.eclipse.che.api.factory.server.github.GithubApiClient.lambda$getUser$0(GithubApiClient.java:115)
	at org.eclipse.che.api.factory.server.github.GithubApiClient.executeRequest(GithubApiClient.java:260)
	at org.eclipse.che.api.factory.server.github.GithubApiClient.getUser(GithubApiClient.java:109)
	at org.eclipse.che.api.factory.server.github.GithubPersonalAccessTokenFetcher.isValid(GithubPersonalAccessTokenFetcher.java:214)
	at org.eclipse.che.api.factory.server.scm.ScmPersonalAccessTokenFetcher.isValid(ScmPersonalAccessTokenFetcher.java:65)
	at org.eclipse.che.api.factory.server.scm.kubernetes.KubernetesPersonalAccessTokenManager.doGetPersonalAccessToken(KubernetesPersonalAccessTokenManager.java:187)
	at org.eclipse.che.api.factory.server.scm.kubernetes.KubernetesPersonalAccessTokenManager.get(KubernetesPersonalAccessTokenManager.java:152)
	at jdk.internal.reflect.GeneratedMethodAccessor135.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at com.google.inject.internal.DelegatingInvocationHandler.invoke(DelegatingInvocationHandler.java:50)
	at com.sun.proxy.$Proxy101.get(Unknown Source)
	at org.eclipse.che.api.factory.server.scm.AbstractGitUserDataFetcher.fetchGitUserData(AbstractGitUserDataFetcher.java:59)
	at org.eclipse.che.workspace.infrastructure.kubernetes.namespace.configurator.GitconfigUserDataConfigurator.configure(GitconfigUserDataConfigurator.java:57)
	at org.eclipse.che.workspace.infrastructure.kubernetes.namespace.KubernetesNamespaceFactory.configureNamespace(KubernetesNamespaceFactory.java:534)
	at org.eclipse.che.workspace.infrastructure.openshift.project.OpenShiftProjectFactory.getOrCreate(OpenShiftProjectFactory.java:120)
	at org.eclipse.che.workspace.infrastructure.openshift.project.OpenShiftProjectFactory.getOrCreate(OpenShiftProjectFactory.java:58)
	at org.eclipse.che.workspace.infrastructure.kubernetes.provision.NamespaceProvisioner.provision(NamespaceProvisioner.java:42)
	at org.eclipse.che.workspace.infrastructure.kubernetes.api.server.KubernetesNamespaceService.provision(KubernetesNamespaceService.java:95)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.everrest.core.impl.method.DefaultMethodInvoker.invokeMethod(DefaultMethodInvoker.java:174)
	at org.everrest.core.impl.method.DefaultMethodInvoker.invokeMethod(DefaultMethodInvoker.java:61)
	at org.everrest.core.impl.RequestDispatcher.doInvokeResource(RequestDispatcher.java:329)
	at org.everrest.core.impl.RequestDispatcher.invokeSubResourceMethod(RequestDispatcher.java:319)
	at org.everrest.core.impl.RequestDispatcher.dispatch(RequestDispatcher.java:257)
	at org.everrest.core.impl.RequestDispatcher.dispatch(RequestDispatcher.java:131)
	at org.everrest.core.impl.RequestHandlerImpl.handleRequest(RequestHandlerImpl.java:61)
	at org.everrest.core.impl.EverrestProcessor.process(EverrestProcessor.java:130)
	at org.everrest.core.servlet.EverrestServlet.service(EverrestServlet.java:62)
	at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:631)
	at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:290)
	at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:280)
	at com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:184)
	at com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:89)
	at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)
	at org.eclipse.che.core.metrics.ApiResponseMetricFilter.doFilter(ApiResponseMetricFilter.java:46)
	at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
	at org.eclipse.che.multiuser.api.authentication.commons.filter.MultiUserEnvironmentInitializationFilter.doFilter(MultiUserEnvironmentInitializationFilter.java:161)
	at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
	at org.eclipse.che.commons.logback.filter.RequestIdLoggerFilter.doFilter(RequestIdLoggerFilter.java:50)
	at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
	at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:121)
	at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:133)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:174)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:149)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:166)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:493)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:115)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
	at org.apache.catalina.valves.RemoteIpValve.invoke(RemoteIpValve.java:738)
	at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:676)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:357)
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:400)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:894)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1741)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
	at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191)
	at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	at java.base/java.lang.Thread.run(Thread.java:829)
2023-07-07 11:31:31,713[nio-8080-exec-2]  [ERROR] [o.e.c.a.f.s.g.GithubApiClient 118]   - Error while parsing response body No content to map due to end-of-input
 at [Source: (jdk.internal.net.http.ResponseSubscribers$HttpResponseInputStream); line: 1, column: 0]

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4551

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

ibuziuk

@vinokurig can we add some tests for the fix?

vinokurig · 2023-07-11T12:24:43Z

@ibuziuk This is already covered with tests. The issue is that we can not reproduce the error in our known environment.

ibuziuk · 2023-07-11T12:37:44Z

@artaleks9 could you please take a look why ci/prow/v12-github-with-pat-setup-flow is failing?

tolusha · 2023-07-11T12:39:34Z

/retest

tolusha · 2023-07-11T12:40:24Z

Can we be sure that this does not affect the current behavior?

vinokurig · 2023-07-11T12:43:15Z

@tolusha

Can we be sure that this does not affect the current behavior?

I have tested this with GitHub flow, all API clients are covered with tests.

openshift-ci · 2023-07-12T07:19:46Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Pass string to ObjectMapper instead of InputStream in order to avoid No content to map due to end-of-input error caused by jdk.internal.net.http.ResponseSubscribers$HttpResponseInputStream. An error was discovered in our customers environment

devstudio-release · 2023-07-15T00:32:00Z

Build 3.9 :: server_3.x/185: Console, Changes, Git Data

devstudio-release · 2023-07-15T01:06:41Z

Build 3.9 :: sync-to-downstream_3.x/3769: Console, Changes, Git Data

devstudio-release · 2023-07-15T01:45:12Z

Build 3.9 :: get-sources-rhpkg-container-build_3.x/3617: Console, Changes, Git Data

devstudio-release · 2023-07-15T03:33:17Z

Build 3.9 :: push-latest-container-to-quay_3.x/2730: Console, Changes, Git Data

devstudio-release · 2023-07-15T03:39:14Z

Build 3.9 :: get-sources-rhpkg-container-build_3.x/3617:

server : 3.x :: Build 53944826 : quay.io/devspaces/server-rhel8:3.9-1
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/2730 triggered

devstudio-release · 2023-07-15T03:39:17Z

Build 3.9 :: server_3.x/185:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3769 triggered

devstudio-release · 2023-07-15T03:52:47Z

Build 3.9 :: update-digests_3.x/3681: Console, Changes, Git Data

devstudio-release · 2023-07-15T03:57:01Z

Build 3.9 :: operator-bundle_3.x/1598: Console, Changes, Git Data

devstudio-release · 2023-07-16T08:41:38Z

Build 3.9 :: server_3.x/186: Console, Changes, Git Data

devstudio-release · 2023-07-16T12:26:39Z

Build 3.9 :: sync-to-downstream_3.x/3774: Console, Changes, Git Data

devstudio-release · 2023-07-23T08:49:16Z

Build 3.9 :: server_3.x/187: Console, Changes, Git Data

devstudio-release · 2023-07-23T08:56:58Z

Build 3.9 :: sync-to-downstream_3.x/3807: Console, Changes, Git Data

devstudio-release · 2023-07-23T09:07:07Z

Build 3.9 :: get-sources-rhpkg-container-build_3.x/3656: Console, Changes, Git Data

devstudio-release · 2023-07-23T09:09:20Z

Build 3.9 :: get-sources-rhpkg-container-build_3.x/3656:

server : 3.x :: Failed in 54128420 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Pass string to ObjectMapper instead of InputStream

e79839b

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

vinokurig requested review from l0rd, ibuziuk, nickboldt and tolusha as code owners July 11, 2023 11:22

ibuziuk reviewed Jul 11, 2023

View reviewed changes

ibuziuk approved these changes Jul 11, 2023

View reviewed changes

openshift-ci bot assigned ibuziuk Jul 11, 2023

openshift-ci bot added the lgtm label Jul 11, 2023

tolusha approved these changes Jul 12, 2023

View reviewed changes

openshift-ci bot assigned tolusha Jul 12, 2023

vinokurig merged commit c5963e0 into main Jul 12, 2023
4 checks passed

vinokurig deleted the CRW-4551 branch July 12, 2023 07:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass string to ObjectMapper instead of InputStream #531

Pass string to ObjectMapper instead of InputStream #531

vinokurig commented Jul 11, 2023

ibuziuk left a comment

vinokurig commented Jul 11, 2023

ibuziuk commented Jul 11, 2023

tolusha commented Jul 11, 2023

tolusha commented Jul 11, 2023

vinokurig commented Jul 11, 2023 •

edited

Loading

openshift-ci bot commented Jul 12, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 16, 2023

devstudio-release commented Jul 16, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

Pass string to ObjectMapper instead of InputStream #531

Pass string to ObjectMapper instead of InputStream #531

Conversation

vinokurig commented Jul 11, 2023

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

ibuziuk left a comment

Choose a reason for hiding this comment

vinokurig commented Jul 11, 2023

ibuziuk commented Jul 11, 2023

tolusha commented Jul 11, 2023

tolusha commented Jul 11, 2023

vinokurig commented Jul 11, 2023 • edited Loading

openshift-ci bot commented Jul 12, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 15, 2023

devstudio-release commented Jul 16, 2023

devstudio-release commented Jul 16, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

devstudio-release commented Jul 23, 2023

vinokurig commented Jul 11, 2023 •

edited

Loading