-
Notifications
You must be signed in to change notification settings - Fork 111
chore: faster build of docker images #1279
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Codecov Report
@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
+ Coverage 32.78% 36.36% +3.57%
==========================================
Files 290 325 +35
Lines 9885 10574 +689
Branches 1457 1367 -90
==========================================
+ Hits 3241 3845 +604
- Misses 6641 6724 +83
- Partials 3 5 +2
Continue to review full report at Codecov.
|
@@ -13,7 +13,6 @@ set -e | |||
set -o pipefail | |||
|
|||
parse "$@" | |||
yarn ${YARN_OPTS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building it with yarn allows failing faster when there's a compilation error. So, not to wait while it fails within a docker build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, as we have a dedicated GH action for validating sources build, it's a good idea to get rid of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, take care of the --root-yarn-opts
parameter as well. Otherwise, we'll have the dead code.
See the details in the PR https://github.com/eclipse-che/che-theia/pull/725/files
Also, need to check ./build.sh --root-yarn-opts:--ignore-scripts
calls.
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
What does this PR do?
Removes pre-building of Che-Theia before building of docker images.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
No issue
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable