Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Docker image for PHP Language Support and Debugger #203

Merged
merged 1 commit into from
May 28, 2019

Conversation

vrubezhny
Copy link
Contributor

@vrubezhny vrubezhny commented May 3, 2019

Based on che-theia-endpoint-runtime image.

Includes the following php7 packages:

php7 php7-fpm php7-opcache
php7-gd php7-mysqli php7-zlib php7-curl
php7-xdebug

In order to be used for VSCode PHP Language Support and Debugger extensions, it should be built using --tag=next which will add the support for node:10.15 and the latest VSCode API support required to run the mentioned VSCode extensions.

Signed-off-by: Victor Rubezhny vrubezhny@redhat.com

What does this PR do?

Adds a docker image that is to be used in Che7 for PHP Language Support and Debugger and includes all the pre-requisite packages required to run the PHP plugins.

What issues does this PR fix or reference?

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented May 3, 2019

Can one of the admins verify this patch?

@benoitf
Copy link
Contributor

benoitf commented May 6, 2019

ci-build

dockerfiles/remote-plugin-php7/Dockerfile Outdated Show resolved Hide resolved
dockerfiles/remote-plugin-php7/Dockerfile Outdated Show resolved Hide resolved
Based on che-theia-endpoint-runtime image.

Includes the following php7 packages:

    php7 php7-fpm php7-opcache
    php7-gd php7-mysqli php7-zlib php7-curl
    php7-xdebug

In order to be used for VSCode PHP Language Support and Debugger extensions, it should be built using `--tag=next` which
will add the support for node:10.15 and the latest VSCode API support required to run the mentioned VSCode extensions.

Issue: eclipse-che/che#12772

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@vrubezhny
Copy link
Contributor Author

I've updated the Dockerfile for the image in order to reduce the layers according to @benoitf and @monaka notes.
Please, verify.

@monaka monaka requested review from monaka and benoitf May 24, 2019 08:22
@svor
Copy link
Contributor

svor commented May 28, 2019

@benoitf @evidolob Could you please take a look

@svor svor merged commit 5a3cdc5 into eclipse-che:master May 28, 2019
monaka pushed a commit to PizzaFactory/che-theia that referenced this pull request Jun 14, 2019
Based on che-theia-endpoint-runtime image.

Includes the following php7 packages:

    php7 php7-fpm php7-opcache
    php7-gd php7-mysqli php7-zlib php7-curl
    php7-xdebug

In order to be used for VSCode PHP Language Support and Debugger extensions, it should be built using `--tag=next` which
will add the support for node:10.15 and the latest VSCode API support required to run the mentioned VSCode extensions.

Issue: eclipse-che/che#12772

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
switch all versions from '7.0.0-next' to the 'next'
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants