Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Put the dummy post-install.log file. #308

Closed
wants to merge 1 commit into from

Conversation

monaka
Copy link
Member

@monaka monaka commented Jun 26, 2019

What does this PR do?

Puts the dummy post-install.log file.
It is for avoiding a check by eclipse-theia/theia#5055.

What issues does this PR fix or reference?

fixes #306

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
@monaka monaka requested review from benoitf and evidolob as code owners June 26, 2019 06:48
@benoitf
Copy link
Contributor

benoitf commented Jun 26, 2019

@monaka is it needed with #307 ?

@evidolob
Copy link
Contributor

We do not need this as eclipse-theia/theia#5587 are merged

@monaka
Copy link
Member Author

monaka commented Jun 26, 2019

I agree heia-ide/theia#5587 is better than this. I close this as won't fix.

@monaka monaka closed this Jun 26, 2019
@monaka monaka deleted the pr-put-dummy-post-install.log-file branch June 26, 2019 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build Theia on Alpine Linux
3 participants