-
Notifications
You must be signed in to change notification settings - Fork 111
Fix resolving of variables for che commands #373
Conversation
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
I want to test this branch. |
@AndrienkoAleksandr |
It would be nice to add resolving the variables in |
maybe it's implemented on machine-exec level, because I see that variables are used for |
che-machine-exec doesn't do such things. |
|
@AndrienkoAleksandr @azatsarynnyy |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@AndrienkoAleksandr @azatsarynnyy @olexii4 btw: I updated the images for testing (No pressure, just info for case if somebody wants to try it). |
Tested, works fine. |
@slemeur |
I'm +1 for it. |
What does this PR do?
Allows to resolve variables for che commands before execution.
For example you can define command in your devfile:
and
${workspaceFolder}
will be replaced by/projects
for example, or use${file}
to get path tothe file opened in the current editor
What issues does this PR fix or reference?
eclipse-che/che#14031
How to test
Use the component in your devfile
The image contains:
Use a command with variables in your devfile, the simple example you can see above.