Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fixup: Hide Plugins view from upstream #425

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

vitaliy-guliy
Copy link
Contributor

Signed-off-by: Vitaliy Guliy vgulyy@redhat.com

What does this PR do?

Fixes appearing two View > Plugins items in top menu

Screenshot from 2019-09-02 16-31-40

What issues does this PR fix or reference?

eclipse-che/che#13670

Signed-off-by: Vitaliy Guliy <vgulyy@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 3, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@vitaliy-guliy
Copy link
Contributor Author

@musienko-maxim could you please give a look at the failing tests?

@AndrienkoAleksandr
Copy link
Contributor

@musienko-maxim in PTO

@l0rd
Copy link
Contributor

l0rd commented Sep 3, 2019

@eclipse/eclipse-che-qa can you please have a look if you are not looking at it yet?

@ibuziuk ibuziuk mentioned this pull request Sep 3, 2019
21 tasks
@dmytro-ndp
Copy link
Contributor

crw-ci-test

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Sep 3, 2019

@vitaliy-guliy, @l0rd: explanation to failure #425 (comment): there were changes in chectl parameters list:

00:29:45.832 + /usr/local/bin/chectl server:start --k8spodreadytimeout=180000 --templates=/mnt/hudson_workspace/workspace/Che-Theia-PR-check-E2E-Happy-path-tests-against-K8S/che/deploy/ --listr-renderer=verbose
00:29:46.458  ›   Error: --platform parameter is mandatory. The command 'chectl server:start 

I have added corresponding parameter to PR check job and restarted the tests.

@che-bot
Copy link
Contributor

che-bot commented Sep 3, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually. Works like expected - we have only one Plugins panel from che-theia.

@dmytro-ndp
Copy link
Contributor

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 3, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 3, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

@AndrienkoAleksandr AndrienkoAleksandr merged commit 1165020 into master Sep 3, 2019
@AndrienkoAleksandr AndrienkoAleksandr deleted the hide-plugins-view branch September 3, 2019 14:52
@vitaliy-guliy
Copy link
Contributor Author

@AndrienkoAleksandr thanks for merging!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants