This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Modify 'configStorage' path for remote plugin #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob
requested review from
benoitf,
tolusha,
AndrienkoAleksandr and
mmorhun
AndrienkoAleksandr
approved these changes
Oct 15, 2019
tsmaeder
reviewed
Oct 15, 2019
| // Modify 'configStorage' objects path, to use current user home directory | ||
| // in remote plugin image '/home/theia' doesn't exist | ||
| const originalStart = PluginManagerExtImpl.prototype.$start; | ||
| PluginManagerExtImpl.prototype.$start = async function (params: PluginManagerStartParams): Promise<void> { |
There was a problem hiding this comment.
This looks like a hack: if the storage path is not in fact determined from the parameters, we should refactor the plugin API to make the storage path the responsiblity of the plugin runner.
I understand that we're trying to get this in urgently, so we do a solution in che-theia, but could we open an issue on the theia repo to do the refactoring?
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
benoitf
approved these changes
Oct 15, 2019
|
Yes, it required for 7.3.0, I'm going to create issue in Theia repository: eclipse-theia/theia#6395 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modify 'configStorage' path for remote plugin, as
/home/theia/may not present in remote plugin imageWhat issues does this PR fix or reference?
eclipse-che/che#14797