Apply terminal title name configuration

[vinokurig]

What does this PR do?

Add a configuration that controls default terminal title override:

How to test?

Start a workspace from dev-file that contains a custom container that changes terminal title e.g:

- alias: my-container
    type: dockerimage
    image: ivinokur/rhel8
    mountSources: true
    memoryLimit: 256M

What issues does this PR fix or reference?

fixes eclipse-che/che#15242

Release Notes

Docs PR

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	docker.io/maxura/che-theia:606
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:606

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

[azatsarynnyy]

Looks well.
Just one question: where the tab labels come from? container-1, container-2, ...

[vinokurig]

@azatsarynnyy The default terminal title name comes from the dev-file

[RomanNikitenko]

Tested using component based on eivantsov/rhel8 image.
Works well for me!

[AndrienkoAleksandr]

General OK. But I think you can extend original theia terminal preference schema. Any way up to you.

[benoitf]

Hello,

to me the property name is confusing. I expect that override is when container name is added (like the opposite)

BTW, as the naming of title/terminals is quite confusing in the Che context, shouldn't it be the default ?
By default, users opening terminals should see the container name as prefix without having to update some preferences.

[benoitf]

@dmytro-ndp I tried with che-bot links to review but it seems it's not using the right images so I wasn't able to test by clicking.

  containers:
   - name: theia-ide
     image: "quay.io/eclipse/che-theia:next"

[vinokurig]

@benoitf

to me the property name is confusing. I expect that override is when container name is added (like the opposite)

How about allowToChangeTitle ?

[benoitf]

I'm still wondering if we need to have a property or just prefix with container all the time ?

[vinokurig]

I prefer to keep the property. Title with both container name and overridden title looks too long:

@slemeur @l0rd WDYT?

[benoitf]

I think we could shorter the title
We already know we're inside a terminal so no need to have terminal 0, terminal 1
container-short-name#1'is enough + hover with full name (I'm unsure as well that first terminal should be 0 for humans)

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	docker.io/maxura/che-theia:606
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:606

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

[vinokurig]

@benoitf I like your solution but we need to have agreement with @slemeur and @l0rd because the corresponding issue is about adding a property and viewing only default title or title from container: eclipse-che/che#15242

[l0rd]

@vinokurig I agree with @benoitf
Moreover I am not sure if there is any value in having the property: it should always be overrideTitle=false. As a user why should I be interested in setting "terminal.overrideTitle": true? cc @AndrienkoAleksandr

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	docker.io/maxura/che-theia:606
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:606

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	docker.io/maxura/che-theia:606
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:606

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

[AndrienkoAleksandr]

Moreover I am not sure if there is any value in having the property: it should always be overrideTitle=false. As a user why should I be interested in setting "terminal.overrideTitle": true? cc @AndrienkoAleksandr

Show terminal title - it is a feature. I think most users don't need it. But I can not predict desire all users, that's why for me make sense to have an option.

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	docker.io/maxura/che-theia:606
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:606

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

[vinokurig]

@benoitf @l0rd I have updated the PR to have both container name and container title in the terminal title:

Can we go with it?

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	docker.io/maxura/che-theia:606
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:606

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)