This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Introduce endpoint discovery / automatic port pickup / all-in-one docker images #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
force-pushed
the
discovery-endpoint
branch
from
6d55e3e
to
12277c5
Compare
…the same network (so sidecar container could be discovered automatically) Also introduce automatic port if port is already in used (so for example if you run three or four endpoints it won't collide) note: if port is specified then it doesn't take unassigned ports It allows as well pure docker image of sidecar + plug-ins Change-Id: If0c0b58814892b1dbbe6d8b04e8fb5e7691ef820 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
discovery-endpoint
branch
from
12277c5
to
4b70a8a
Compare
benoitf
changed the title
evidolob
approved these changes
Mar 6, 2019
vitaliy-guliy
approved these changes
Mar 6, 2019
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce:
Change-Id: If0c0b58814892b1dbbe6d8b04e8fb5e7691ef820
Signed-off-by: Florent Benoit fbenoit@redhat.com