This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
chore(devfile): che-theia devfile to work on plugins #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sun Tan <sutan@redhat.com>
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
sunix
requested review from
azatsarynnyy,
benoitf,
ericwill,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
benoitf
reviewed
Feb 9, 2021
benoitf
reviewed
Feb 9, 2021
benoitf
reviewed
Feb 9, 2021
| exit 1; | ||
| fi | ||
| done | ||
| SKIP_TEST=true SKIP_FORMAT=true SKIP_LINT=true yarn --cwd=$project_folder |
There was a problem hiding this comment.
in one case (when of build it's doing tests/checks and here it's skipping checks
fine for me b/c I like TDD but I don't know if it's the flow for all devs ?
There was a problem hiding this comment.
Let's see if someone complains and we will figure out :)
benoitf
reviewed
Feb 9, 2021
benoitf
approved these changes
Feb 9, 2021
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
azatsarynnyy
approved these changes
Feb 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sun Tan sutan@redhat.com
What does this PR do?
A devfile for dogfooding. At the moment it covers only the plugins dev flow.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Part of eclipse-che/che#18763
How to test this PR?
che-theiarepo/projects/che-theia/plugins/welcome-pluginfor instancesrc/welcome-plugin.tsbuild ... current yarn project: it should build the project (may take a while the first time)test-watch ... current yarn project: it should fail as there is no tests in this plugin. For plugins with tests, it should run the test in watch mode: any changes on files would restart the test and warn the developer if a test is failling.src/welcome-plugin.ts, for instance:build current plugin ... and run with che-theiait should build the plugin (without format/lint/test checks) and start che-theia. it should only take few secondssrc/welcome-plugin.ts, for instance:build current plugin ... and run with che-theiaPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable