Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block workspaces based on old model if Che is still able to run them #13534

Closed
slemeur opened this issue Jun 13, 2019 · 2 comments
Closed
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@slemeur
Copy link
Contributor

slemeur commented Jun 13, 2019

Description

Right now Che is still available to run the workspaces which are based on the old model (GWT IDE and agents). But if a user has created one of those workspaces (from a stack or from a workspace definition), he'll be block with it, not being able to open it anymore.

The current behavior introduced by #13284 would be good, only when we would have remove completely the compatibility with the old model of workspaces.
(Should this be parameterized? or enabled only when a flag will be present?)

Until those workspaces can still run, we should not prevent the user from running them.

Reproduction Steps

  • Create a workspace using a definition which will rely on the GTW IDE and Che 6 model
  • Stop it
  • See that you can't run it anymore
@slemeur slemeur added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/ide2 labels Jun 13, 2019
@slemeur slemeur changed the title Workspaces Don't block workspaces based on old model if Che is still able to run them Jun 13, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Jun 21, 2019

@slemeur I think we can close this now since 7.0.0-RC-1.1 has been released

@che-bot
Copy link
Contributor

che-bot commented Dec 18, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2019
@che-bot che-bot closed this as completed Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants