Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-12917 Added an indicator to notify that the CHE 6 workspaces will not work anymore #13284

Merged
merged 3 commits into from
May 21, 2019

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented May 6, 2019

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Added a visual indicator to notify the user that the CHE 6 workspaces will not work anymore and needs to be converted as a CHE 7 workspaces.

What issues does this PR fix or reference?

#12917

- display a visual indicator to notify the user that the CHE 6 workspace will not work anymore.

Release Notes

Docs PR

https://youtu.be/KnbFbQaPAbo

@olexii4
Copy link
Contributor Author

olexii4 commented May 6, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 6, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13284
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4
Copy link
Contributor Author

olexii4 commented May 6, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 6, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13284
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4
Copy link
Contributor Author

olexii4 commented May 8, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 8, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13284
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@olexii4 olexii4 requested a review from SkorikSergey May 10, 2019 08:58
@olexii4
Copy link
Contributor Author

olexii4 commented May 10, 2019

@SkorikSergey Che 6 based workspaces are not going to remain compatible with Che 7 and this PR remove the ability to start the Che 6 workspace. Could you add the needed commit?

@SkorikSergey
Copy link
Contributor

@SkorikSergey Che 6 based workspaces are not going to remain compatible with Che 7 and this PR remove the ability to start the Che 6 workspace. Could you add the needed commit?

I think we need to delete from test suite all selenium tests that check workspace start/stopping from Dashboard. I will add changes to this PR.

@SkorikSergey
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 10, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13284
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 10, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13284
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@slemeur
Copy link
Contributor

slemeur commented May 14, 2019

Can change the wording that is used?

  • Instead of "Not supported" in the list of workspaces "Not compatible"
  • In the tooltip "This workspace is not supported in the current version of the product." by "This workspace is using old definition format which is not compatible anymore. Please follow the documentation to update the definition of the workspace and benefits from the latest capabilities."
  • In the header of the detail page: "This workspace is using old definition format which is not compatible anymore. Please follow the documentation [Add link to create workspace] to update the definition of the workspace and benefits from the latest capabilities."

BTW, is that not easier to simply recreate a new workspace based on the new stack?

@olexii4
Copy link
Contributor Author

olexii4 commented May 14, 2019

@slemeur As for me, it is easier just to add needed plugins(all installers should be automatically removed after)

@olexii4
Copy link
Contributor Author

olexii4 commented May 17, 2019

@slemeur Done
Screenshot from 2019-05-17 14-55-01

Screenshot from 2019-05-17 14-58-47

@gorkem
Copy link
Contributor

gorkem commented May 18, 2019

This is a good step forward but I think we can also add a button to convert to latest specification and to the conversion for the user, can't we ?

@slemeur
Copy link
Contributor

slemeur commented May 18, 2019

@gorkem : We are not intending to do automatic convertion of che 6 workspace definition to che 7 workspace definition. While being nice, we removed that from the scope and will cover that with docs.

@gorkem
Copy link
Contributor

gorkem commented May 18, 2019

@slemeur scope suggests a release. We should still have it as an item on the backlog

@olexii4
Copy link
Contributor Author

olexii4 commented May 20, 2019

@gorkem Yes, we can add a button to convert to the latest specification.

@slemeur What should I do for this PR?

@slemeur
Copy link
Contributor

slemeur commented May 21, 2019

@olexii4 : The PR is good to go. Automatic convertion would need a different issue and analyze anyway.

@olexii4 olexii4 merged commit 57ad0e1 into master May 21, 2019
@olexii4 olexii4 deleted the CHE-12917 branch May 21, 2019 12:10
@pavangayakwad
Copy link

Guys! where is the documentation to troubleshoot this error? I have been searching for this and it is nowhere.

@slemeur
Copy link
Contributor

slemeur commented Jun 3, 2019

cc @rkratky .

Hi @pavangayakwad, If you want to move a Che 6 workspace to a Che 7 workspaces, we would recommend you to create a devfile. You can learn more about devfile on the following repository (will be turned into documentation on che's docs):

Please let us know how this goes and if you have any issues, please create a new one Che repository. You'll not be the only user to do that effort and sharing the experience would be valuable to the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants