Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant dialog appears on git checkout from status bar #13974

Closed
6 of 23 tasks
vinokurig opened this issue Jul 23, 2019 · 1 comment · Fixed by eclipse-theia/theia#6236
Closed
6 of 23 tasks

Redundant dialog appears on git checkout from status bar #13974

vinokurig opened this issue Jul 23, 2019 · 1 comment · Fixed by eclipse-theia/theia#6236
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Milestone
7.2.0

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Jul 23, 2019 •
edited
Loading

Describe the bug

vscode Git SCM extension provides branch indicator to status bar. The branch indicator has a checkout action. The checkout action must view branches of the selected SCM repository to checkout, but currently it asks to select a repository before viewing the branch list.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Open a workspace with several projects with initialized Git
  2. Click the branch indicator in the status bar:
    screenshot-che-che 192 168 39 229 nip io-2019 07 23-15-15-00

WRONG: A dialog with repository list appears:
screenshot-che-che 192 168 39 229 nip io-2019 07 23-15-20-12

Expected behavior

A dialog with brunch list must be shown without selecting the repository, It must detect selected repository from the SCM.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context
@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. area/editor/theia Issues related to the che-theia IDE of Che labels Jul 23, 2019
@nickboldt nickboldt added the severity/P2 Has a minor but important impact to the usage or development of the system. label Jul 24, 2019
@nickboldt nickboldt added this to the 7.2.0 milestone Jul 24, 2019
@nickboldt
Copy link
Contributor

+1, usability should be improved here. But no function is blocked, so punting to P2/7.2.

@vparfonov vparfonov mentioned this issue Aug 7, 2019
Closed
11 tasks
@vparfonov vparfonov mentioned this issue Sep 3, 2019
Closed
19 tasks
@vinokurig vinokurig added the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 16, 2019
This was referenced Sep 18, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Milestone
7.2.0
3 participants
@nickboldt @vparfonov @vinokurig