Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCM] Fix SCM status bar commands #6236

Merged
merged 1 commit into from
Sep 23, 2019
Merged

[SCM] Fix SCM status bar commands #6236

merged 1 commit into from
Sep 23, 2019

Conversation

vinokurig
Copy link
Contributor

What it does

Pass command arguments to SCM status bar commands. Map command.id to command.command in statusBarCommands and acceptInputCommand

How to test

  1. Clone the test plugin: https://github.com/vinokurig/Test.git
  2. Compile the plugin and start it as a hosted instance.
  3. Select the / SCM repository (this is a view of a dummy SCM repository):
    screenshot-localhost-3030-2019 09 06-17-34-24
  4. Click title button in the status bar:
    screenshot-localhost-3030-2019 09 18-15-18-52

See the notification

fixes eclipse-che/che#13974

Review checklist

Reminder for reviewers

@vinokurig
[SCM] Fix SCM stats bar commands
13fccec 
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@vinokurig vinokurig added plug-in system issues related to the plug-in system scm issues related to the source control manager labels Sep 20, 2019
@vinokurig vinokurig requested a review from akosyakov September 20, 2019 12:23
@vinokurig vinokurig changed the title [SCM] Fix SCM stats bar commands [SCM] Fix SCM status bar commands Sep 20, 2019
akosyakov
akosyakov approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well, thank you!

@vinokurig vinokurig merged commit 8196e9d into master Sep 23, 2019
@vinokurig vinokurig deleted the CHE-13974 branch September 23, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
plug-in system issues related to the plug-in system scm issues related to the source control manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundant dialog appears on git checkout from status bar
2 participants
@vinokurig @akosyakov