Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vscode marketplace support from plugin broker #15054

Closed
amisevsk opened this issue Oct 31, 2019 · 4 comments
Closed

Remove vscode marketplace support from plugin broker #15054

amisevsk opened this issue Oct 31, 2019 · 4 comments
Labels
area/plugin-broker kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.8.0

Comments

@amisevsk
Copy link
Contributor

amisevsk commented Oct 31, 2019 •
edited
Loading

Is your task related to a problem? Please describe.

The plugin broker allows plugins to specify vsix extensions directly from the vscode marketplace, via e.g.

extensions:
  - vscode:extension/ms-kubernetes-tools.vscode-kubernetes-tools

Since we 1) do not use this functionality currently, and 2) should not be pulling directly from the vscode marketplace for plugins, this functionality should be deprecated/removed.

The code for resolving these links and trying them ends up increasing the complexity in plugin broker, and it could be a lot simpler without it.
@amisevsk amisevsk added kind/task Internal things, technical debt, and to-do tasks to be performed. area/plugin-broker team/osio labels Oct 31, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 31, 2019
@tsmaeder tsmaeder added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 31, 2019
@ibuziuk ibuziuk modified the milestones: Backlog - Hosted Che, 7.6.0 Nov 21, 2019
@ibuziuk
Copy link
Member

ibuziuk commented Nov 27, 2019

We should take into account - #15322

@amisevsk
Copy link
Contributor Author

amisevsk commented Dec 2, 2019

@ibuziuk #15322 is related but separate from this issue, as even if we remove vscode:extension support, direct links to the market place will still work. The fixes are different:

  • For this issue, remove plugin broker logic to resolve vscode:extension references
  • For Don't use marketplace in node/node2 Che plugins. #15322, the registry needs to be updated to not point at the marketplace; the broker doesn't care what the URL is as long as it spits out a vsix.

@amisevsk amisevsk mentioned this issue Dec 3, 2019
Merged
@amisevsk
Copy link
Contributor Author

amisevsk commented Dec 4, 2019

Refactor PR eclipse-che/che-plugin-broker#80 includes this change.

@nickboldt
Copy link
Contributor

Closing as this appears to have been done in Che 7.8 as part of the broker refactoring. \o/

@nickboldt nickboldt modified the milestones: 7.6.0, 7.8.0 Mar 3, 2020
@tsadigovAgmail tsadigovAgmail mentioned this issue May 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugin-broker kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.8.0
Development

No branches or pull requests
5 participants
@nickboldt @ibuziuk @tsmaeder @amisevsk @che-bot