Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use marketplace in node/node2 Che plugins. #15322

Closed
tsmaeder opened this issue Nov 26, 2019 · 4 comments
Closed

Don't use marketplace in node/node2 Che plugins. #15322

tsmaeder opened this issue Nov 26, 2019 · 4 comments
Labels
area/languages Issues related to Language extensions or plugins integration. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@tsmaeder
Copy link
Contributor

We are currently referencing the VS Code marketplace in our node/node2 debug Che plugins. We need to host the vsix file on github.com/redhat-developer and reference it there.

See also: [plugin registry] Do not reference marketplace.visualstudio.com in plugin registry meta.yaml #14573
@tsmaeder tsmaeder added kind/task Internal things, technical debt, and to-do tasks to be performed. area/languages Issues related to Language extensions or plugins integration. team/languages labels Nov 26, 2019
@tsmaeder tsmaeder mentioned this issue Nov 26, 2019
Closed
26 tasks
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 26, 2019
@amisevsk
Copy link
Contributor

Add asciidoctor to the list.

@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 26, 2019
@tsmaeder
Copy link
Contributor Author

@amisevsk I created this issue as a task for the languages team for planning purposes. We know nothing about the asciidoctor plugin, so leaving that task for whoever added it to the registry.

@ibuziuk ibuziuk mentioned this issue Nov 27, 2019
Closed
@nickboldt
Copy link
Contributor

I think we can close this because:

  1. Node-debug is removed - [plugin registry] remove support for node <... che-plugin-registry#302
  2. Node-debug2 old version is deprecated with auto-update to latest version which is NOT on VSC marketplace: eclipse-che/che-plugin-registry@38b1387
  3. asciidoctor is now available from GH releases, and older version 2.7.6 is deprecated w/ auto-update - eclipse-che/che-plugin-registry@e58ab67 and eclipse-che/che-plugin-registry@4a4bb72

@nickboldt
Copy link
Contributor

nickboldt commented Dec 10, 2019 •
edited
Loading

Note that instead of hosting files on GH we elected to host them on https://download.jboss.org/jbosstools/vscode/ as that's where a lot of existing RH-built projects publish their bits.

Work is ongoing to move more 3rd party-built plugins away from GH and over to dl.jb.o.

See https://issues.jboss.org/browse/CRW-491 for the latest progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/languages Issues related to Language extensions or plugins integration. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nickboldt @l0rd @tsmaeder @amisevsk @che-bot