Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Compatibility Report shows wrong Results #18085

Closed
tsmaeder opened this issue Oct 9, 2020 · 5 comments
Closed

API Compatibility Report shows wrong Results #18085

tsmaeder opened this issue Oct 9, 2020 · 5 comments
Assignees
@benoitf
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Oct 9, 2020

When looking at https://che-incubator.github.io/vscode-theia-comparator/status.html, I noticed that "registerCompletionItemProvider" is marked as "not implemented". However, that API has been present for a long time.
I suspect that a change in the definition of the type "CompletionItemProvider" causes this problem: we should analyze whether this represents real breakage and alternatively fix the tool or the API. FWIW, the change in CompletionItemProvider was:

export interface CompletionItemProvider<T extends CompletionItem = CompletionItem> {

from before:

export interface CompletionItemProvider<T = CompletionItem> {
@tsmaeder tsmaeder added the kind/bug Outline of a bug - must adhere to the bug report template. label Oct 9, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 9, 2020
@ericwill
Copy link
Contributor

ericwill commented Oct 9, 2020

cc @benoitf

@benoitf
Copy link
Contributor

benoitf commented Oct 9, 2020

I saw that this morning, I think the tool is pretty dumb but would be better to still do the change in Theia API.

@benoitf
Copy link
Contributor

benoitf commented Oct 9, 2020

I can take action on that

@yhontyk yhontyk added area/editor/theia Issues related to the che-theia IDE of Che severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 9, 2020
@benoitf benoitf changed the title API Compatibility Report shows wrong Restults API Compatibility Report shows wrong Results Oct 10, 2020
@benoitf benoitf self-assigned this Oct 10, 2020
@benoitf
Copy link
Contributor

benoitf commented Oct 12, 2020

eclipse-theia/theia#8617

@benoitf
Copy link
Contributor

benoitf commented Oct 12, 2020

fixed

@benoitf benoitf closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitf benoitf

Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@benoitf @ericwill @tsmaeder @yhontyk @che-bot