Fix VS Code API compliance #8617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to this VS Code commit: microsoft/vscode@876ea86 Change-Id: Ic1f8d34dcfe0c5ad87e540517b4cb1d21a48d323 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Change-Id: I5ef6376431d2ec9ed519d5f2f6b46053542736cc Signed-off-by: Florent Benoit <fbenoit@redhat.com>
azatsarynnyy
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Upstream vscode has added new constraints on types: microsoft/vscode@876ea86
Make it compliant
Also update default VS Code API to the current VS Code version
How to test
Try out plug-ins like vscode-java etc using some providers, they should work as usual
Review checklist
Reminder for reviewers