Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very high CPU / Memory Request is set on the jwtproxy end #18483

Closed
ibuziuk opened this issue Nov 30, 2020 · 2 comments
Closed

Very high CPU / Memory Request is set on the jwtproxy end #18483

ibuziuk opened this issue Nov 30, 2020 · 2 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Nov 30, 2020

Is your enhancement related to a problem? Please describe.

jwt proxy is the only container that specifies CPU limit atm which is pretty high:

    Limits:
      cpu:     500m
      memory:  134217728
    Requests:
      cpu:     500m
      memory:  134217728

According to the 3.11 graphs request should be fairly low:

image

Describe the solution you'd like

memory request - 10 Mb
CPU request - 0.02 cores

Describe alternatives you've considered

Additional context

@ibuziuk
Copy link
Member Author

ibuziuk commented Dec 1, 2020

It looks like currently there are no properties for jwtproxy requests (only limits)

che.server.secure_exposer.jwtproxy.memory_limit=128mb
che.server.secure_exposer.jwtproxy.cpu_limit=0.5

so, I believe we need to introduce two new properties:

che.server.secure_exposer.jwtproxy.memory_request
che.server.secure_exposer.jwtproxy.cpu_request

The default values for the request could be 10md and 0.01 according to the metrics:

image

@sparkoo
Copy link
Member

sparkoo commented Dec 9, 2020

docs issue is created. As docs PRs are merged after the release, I'm closing this issue.

@sparkoo sparkoo closed this as completed Dec 9, 2020
@sparkoo sparkoo reopened this Dec 21, 2020
@sparkoo sparkoo closed this as completed Dec 26, 2020
@nickboldt nickboldt added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants