Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cpu and memory request for jwtproxy #18551

Merged
merged 2 commits into from
Dec 9, 2020
Merged

add cpu and memory request for jwtproxy #18551

merged 2 commits into from
Dec 9, 2020

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Dec 7, 2020

Signed-off-by: Michal Vala mvala@redhat.com

What does this PR do?

Adds new config properties for jwtproxy resources requests:

che.server.secure_exposer.jwtproxy.memory_request=15mb
che.server.secure_exposer.jwtproxy.cpu_request=0.03

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#18483

How to test this PR?

  1. start any workspace
  2. take a look at jwtproxy pod mem and cpu requests

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Michal Vala <mvala@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Dec 7, 2020
Signed-off-by: Michal Vala <mvala@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Dec 9, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sparkoo sparkoo merged commit 55f29d6 into eclipse-che:master Dec 9, 2020
@sparkoo sparkoo deleted the gh18483-jwtProxyResources branch December 9, 2020 13:38
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants