Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly enable/disable multi-root in devfiles of che-devfile-registry #19375

Closed
sunix opened this issue Mar 23, 2021 · 8 comments
Closed

Explicitly enable/disable multi-root in devfiles of che-devfile-registry #19375

sunix opened this issue Mar 23, 2021 · 8 comments
Assignees
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current
Milestone

Comments

@sunix
Copy link
Contributor

sunix commented Mar 23, 2021

Is your task related to a problem? Please describe.

Currently multiroot is disabled by default. this is a new feature. Could be enabled in devfile with:

attributes:
 multiRoot: 'on'

Multiroot may be activated by default in the next weeks.
Some devfile may not work yet.

Describe the solution you'd like

The idea of this issue is to explicitly enable or disable multi-root in devfiles of the che-devfile-registry. Enabled if no problem. Disabled if any problem.

@sunix sunix added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Mar 23, 2021
@sunix sunix changed the title explicitly enable/disable multi-root in devfiles of che-devfile-registry Explicitly enable/disable multi-root in devfiles of che-devfile-registry Mar 23, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 23, 2021
@ericwill ericwill mentioned this issue Mar 23, 2021
46 tasks
@vzhukovs vzhukovs added area/plugins and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 23, 2021
@sunix
Copy link
Contributor Author

sunix commented Mar 24, 2021

So far:

  • Quarkus Rest API devfile is broken with multiroot: didact.md is referencing a file to open concidering the project root is /projects. Will be fixed with the upcomming PR
  • Golang devfile is broken with multiroot: no code completion.
    • short term: Will turn off multiroot for this devfile.
    • midterm: Would need to investigate what is the proper layout that works with che and multiroot.

@benoitf
Copy link
Contributor

benoitf commented Mar 24, 2021

for golang it's quite disappointing as multi-root workspace should fix imports from the project !

@azatsarynnyy
Copy link
Member

Doesn't it require enabling go modules in multi-root mode?

@sunix
Copy link
Contributor Author

sunix commented Mar 24, 2021

no idea ... I am a Golang newbie

@ericwill ericwill added this to the 7.29 milestone Mar 24, 2021
@sunix
Copy link
Contributor Author

sunix commented Mar 25, 2021

Not related to multi-root: the Java Spring Boot devfile maven build is failing (killed). I tried increasing the memoryLimit to 1G and it works.
Edit: created #19456

@sunix
Copy link
Contributor Author

sunix commented Mar 26, 2021

Not related to multi-root: the python stack does not have code completion....

@sunix
Copy link
Contributor Author

sunix commented Mar 26, 2021

same for python django: no code completion
Also the preview is not working. Maybe CORS (it works in its own window)

Edit: code completion works after refreshing the browser (with and without multiroot)
created for the preview issue: #19459

@sunix
Copy link
Contributor Author

sunix commented Mar 30, 2021

Closing as it has been covered with eclipse-che/che-devfile-registry#359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current
Projects
None yet
Development

No branches or pull requests

6 participants