Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix(multiroot): fix devfiles so it works with default multiroot #359

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

sunix
Copy link
Contributor

@sunix sunix commented Mar 26, 2021

What does this PR do?

Fix all devfiles after turning on multiroot

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#19375

How to test this PR?

With che nightly set the devfile registry to https://sunix-che-devfile-registry-multiroot-vjnfq.surge.sh/devfiles/
and try go-lang stack and quarkus stack

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Sun Tan <sutan@redhat.com>
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway I like the name of the branch :-)

@ericwill ericwill merged commit 62b7dbd into master Mar 26, 2021
@ericwill ericwill deleted the fix-multitoor branch March 26, 2021 19:21
@che-bot che-bot added this to the 7.29 milestone Mar 26, 2021
@RomanNikitenko
Copy link
Member

@sunix
I see the comment from @azatsarynnyy eclipse-che/che#19375 (comment)

Did you try to enable go modules in the devfile?

Also it would be nice (at least for testing goals):

  • give more memory for Go component
  • wait for Loading packages process - you can see the corresponding loader in the status bar when you open a go file after starting a workspace

@RomanNikitenko
Copy link
Member

@sunix
I quickly tested and looks like the code completion works with turned ON multi-root mode.
Also I don't have a lot of errors in the Problems view when the mode is ON.
To have it working I just did exactly what I mentioned in my previous comment above.

the multi-root mode is OFF

multi-root-off

the multi-root mode is ON

multi-root-on

But I have no experience with Go, so maybe I missed something...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants