Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define CheCluster v2alpha1 #19449

Closed
metlos opened this issue Mar 29, 2021 · 1 comment
Closed

Define CheCluster v2alpha1 #19449

metlos opened this issue Mar 29, 2021 · 1 comment
Assignees
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@metlos
Copy link
Contributor

metlos commented Mar 29, 2021

This is a subtask of #19448.

We need to define the CheCluster version v2alpha1 that is going to be the configuration basis for the che aspects of DevWorkspace.

This version should contain all Devworkspace-related configuration options under spec and should keep all the che7-related configuration (basically the CheCluster v1) under spec.che7.

I image it could take the following form:

apiVersion: v2alpha1
kind: CheCluster
metadata:
  ...
spec:
  che7:
    ... all the options from CheCluster v1
  enabled: false
  che7Enabled: true
  gatewayHost: workspaces.acme.com
  gatewayEnabled: true
  ... related image names and other trivia

The first 3 options (che7, enabled and che7enabled) are there to temporarily to handle the coexistence of che7 server and devworkspace and should probably be removed in the future. The rest of the options is copied from the CheManager which is a temporary CRD used currently by DWCO (https://github.com/che-incubator/devworkspace-che-operator/blob/main/apis/che-controller/v1alpha1/component_types.go#L21).

We need to have the code for this CRD in a place that is consumable by both che-operator and devworkspace-che-operator.

@metlos metlos added kind/enhancement A feature request - must adhere to the feature request template. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Mar 29, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 29, 2021
@mshaposhnik mshaposhnik added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 30, 2021
@skabashnyuk skabashnyuk added this to the 7.30 milestone Apr 9, 2021
@skabashnyuk skabashnyuk modified the milestones: 7.30, 7.31 May 5, 2021
metlos added a commit to metlos/che-operator that referenced this issue May 7, 2021
Defines a new version of the CheCluster custom resource and implements
conversion functions that are going to be used by a conversion webhook
(not yet implemented).
@metlos
Copy link
Contributor Author

metlos commented May 21, 2021

This is superseded by #19845. Once we get to the point where we need to define the new CR version, we can revisit this issue or create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants